discordjs/discord.js
2
0
Fork 0
mirror of https://github.com/discordjs/discord.js.git synced 2024-07-08 00:41:18 +12:00
Code Issues Packages Projects Releases Wiki Activity

fix: prevent 'undefined' debug message on intentional shard closure (#9846)

Browse source 
* style: prevent 'undefined' debug message on intentional shard closure

addresses #9594

* refactor(WebSocketManager#destroy): improve debug messaging

cleaner stacktrace format
gracefully closing shards will display an appropriate debug `reason`

* style: unresumable debug messaging

---------

Co-authored-by: Almeida <almeidx@pm.me>
This commit is contained in:
Renegade334 2023-10-21 14:53:41 +01:00 committed by GitHub
parent 5b4a51945c
commit 0e0b85b766
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
packages/discord.js/src/client/websocket/WebSocketManager.js
View file

@ -258,7 +258,7 @@ class WebSocketManager extends EventEmitter {
* @param {number} id The shard id that disconnected
*/
this.client.emit(Events.ShardDisconnect, { code, reason: reasonIsDeprecated, wasClean: true }, shardId);
this.debug(GatewayCloseCodes[code], shardId);
this.debug(`Shard not resumable: ${code} (${GatewayCloseCodes[code] ?? CloseCodes[code]})`, shardId);
return;
}
@ -324,9 +324,9 @@ class WebSocketManager extends EventEmitter {
async destroy() {
if (this.destroyed) return;
// TODO: Make a util for getting a stack
this.debug(`Manager was destroyed. Called by:\n${new Error().stack}`);
this.debug(Object.assign(new Error(), { name: 'Manager was destroyed:' }).stack);
this.destroyed = true;
await this._ws?.destroy({ code: CloseCodes.Normal });
await this._ws?.destroy({ code: CloseCodes.Normal, reason: 'Manager was destroyed' });
}
/**